Discussion:
[Bug 1768431] [NEW] Request to revert SAUCE patches in the 18.04 SRU and update with upstream version
(too old to reply)
bugproxy
2018-05-02 06:30:22 UTC
Permalink
Public bug reported:

== Comment: #0 - UMA KRISHNAN <***@us.ibm.com> - 2018-04-30 14:41:30 ==
---Problem Description---
Request to revert SAUCE patches from 18.04 and apply the patches from next/master.

Below set of cxlflash patches were submitted to Canonical after they
were sent to the community. Based on review comments, there has been
minor changes from that version. This BZ is to request reverting those
SAUCE patches with the ones that are queued in next/master tree for
4.18.

- SAUCE: cxlflash: Preserve number of interrupts for master contexts
- SAUCE: cxlflash: Avoid clobbering context control register value
- SAUCE: cxlflash: Add argument identifier names
- SAUCE: cxlflash: Introduce OCXL backend
- SAUCE: cxlflash: Hardware AFU for OCXL
- SAUCE: cxlflash: Read host function configuration
- SAUCE: cxlflash: Setup function acTag range
- SAUCE: cxlflash: Read host AFU configuration
- SAUCE: cxlflash: Setup AFU acTag range
- SAUCE: cxlflash: Setup AFU PASID
- SAUCE: cxlflash: Adapter context support for OCXL
- SAUCE: cxlflash: Use IDR to manage adapter contexts
- SAUCE: cxlflash: Support adapter file descriptors for OCXL
- SAUCE: cxlflash: Support adapter context discovery
- SAUCE: cxlflash: Support image reload policy modification
- SAUCE: cxlflash: MMIO map the AFU
- SAUCE: cxlflash: Support starting an adapter context
- SAUCE: cxlflash: Support process specific mappings
- SAUCE: cxlflash: Support AFU state toggling
- SAUCE: cxlflash: Support reading adapter VPD data
- SAUCE: cxlflash: Setup function OCXL link
- SAUCE: cxlflash: Setup OCXL transaction layer
- SAUCE: cxlflash: Support process element lifecycle
- SAUCE: cxlflash: Support AFU interrupt management
- SAUCE: cxlflash: Support AFU interrupt mapping and registration
- SAUCE: cxlflash: Support starting user contexts
- SAUCE: cxlflash: Support adapter context polling
- SAUCE: cxlflash: Support adapter context reading
- SAUCE: cxlflash: Support adapter context mmap and release
- SAUCE: cxlflash: Support file descriptor mapping
- SAUCE: cxlflash: Introduce object handle fop
- SAUCE: cxlflash: Setup LISNs for user contexts
- SAUCE: cxlflash: Setup LISNs for master contexts
- SAUCE: cxlflash: Update synchronous interrupt status bits
- SAUCE: cxlflash: Introduce OCXL context state machine
- SAUCE: cxlflash: Register for translation errors
- SAUCE: cxlflash: Support AFU reset
- SAUCE: cxlflash: Enable OCXL operations

Also, there are 3 additional patches added to end of this series that we would like to request being pulled into the SRU stream. These 3 patches address bug fixes.
The commit ids for the patches queued in next/master tree are,

768999d6b1eadc6a13b1fba1886f1708f433d82b scsi: cxlflash: Preserve number of interrupts for master contexts
6c2b116dd38e3fbda10c3e3d5ac80ea7442e4f4d scsi: cxlflash: Avoid clobbering context control register value
fcace1d5e11f518c6f91dd245fa1ac37393b47d3 scsi: cxlflash: Add argument identifier names
863dbdc0552f8bc100df48bb231089c382b89004 scsi: cxlflash: Introduce OCXL backend
f2180daa83950ff8183f70b1b78d67cb13fd90b2 scsi: cxlflash: Hardware AFU for OCXL
1042535633554592d7d95a9cf83d2940803689e0 scsi: cxlflash: Read host function configuration
ba84823a8b448207659753ae4f9c8b956923bada scsi: cxlflash: Setup function acTag range
f55ced2dcd00ab257a2bb25eee619b75cda24817 scsi: cxlflash: Read host AFU configuration
c5a8fec11278e245136c7f696c914269c58a6000 scsi: cxlflash: Setup AFU acTag range
b42d68d728a63337bcb7860b59e6458946d94a84 scsi: cxlflash: Setup AFU PASID
de25ec59a75802584aac97aed05fd94094dbbb58 scsi: cxlflash: Adapter context support for OCXL
a76fc993e399f54b37f46107a31e817c779f2b82 scsi: cxlflash: Use IDR to manage adapter contexts
09f35da5fe218baf73f7b4efd281e2c19490512c scsi: cxlflash: Support adapter file descriptors for OCXL
17f9335bc59c1cf8f93617eee137e745abd71a3f scsi: cxlflash: Support adapter context discovery
a5cfe355f23d4410d69af0e5b196b095463a0b4b scsi: cxlflash: Support image reload policy modification
0c62e7c091a4e0a01a7c6027fe719625ab2f521e scsi: cxlflash: MMIO map the AFU
f39bab766ea4f0b3d5888fdd7d66babd7bef3966 scsi: cxlflash: Support starting an adapter context
bef2014e8bd6391988b588acb969b48133072f17 scsi: cxlflash: Support process specific mappings
58b43437bd85565c74c2b6975cc71003b93f3559 scsi: cxlflash: Support AFU state toggling
08d6154b6064021db6e9b822559f3accfcb0a8f7 scsi: cxlflash: Support reading adapter VPD data
c11b0b435a7b1001d2451cde8dc249cc5ef614a0 scsi: cxlflash: Setup function OCXL link
fad7fd669ac666e411682ca28104a15d035bc957 scsi: cxlflash: Setup OCXL transaction layer
8733bd8b329124fa24d717daa2285adeba0ecc70 scsi: cxlflash: Support process element lifecycle
eb249077b3fb27939f57975dac8c7ec719066d3a scsi: cxlflash: Support AFU interrupt management
8c58d224f173941787f635d3e30ce3479802118c scsi: cxlflash: Support AFU interrupt mapping and registration
87b78b7cadd5518593fee714d1c4ad9e67e5f5b1 scsi: cxlflash: Support starting user contexts
65a9b16c95b48388a845513f0e3ef6db99f8068a scsi: cxlflash: Support adapter context polling
6a6093bab2df2e41f558695697077df5d95fa50b scsi: cxlflash: Support adapter context reading
eff344dc47ce1f3f452d34d7e8801c472b7bd5ec scsi: cxlflash: Support adapter context mmap and release
195fc14998630cff370d1f46c4cd5833072dab7d scsi: cxlflash: Support file descriptor mapping
f9662c034e25c973cc38ee5aebfd2516601f5f75 scsi: cxlflash: Introduce object handle fop
3aeb1833e4e2374c22fe1b3d05affe64a95a0839 scsi: cxlflash: Setup LISNs for user contexts
41676671021c361b75da10e8ad16f95e8daa8090 scsi: cxlflash: Setup LISNs for master contexts
e05df99313b8fedad51f98e74c751a33fbfb6bad scsi: cxlflash: Update synchronous interrupt status bits
6d11971a38cce007899586e98667061a1fddfc23 scsi: cxlflash: Introduce OCXL context state machine
d5c11f5c33fb3edfe6031d38dc650fc5017c4a40 scsi: cxlflash: Register for translation errors
41ef5d04768990f3ab64a8fec581217df65f3f30 scsi: cxlflash: Support AFU reset
6a7969eda1cf4bcb8f8eb8f11a2ebdff24a39ac5 scsi: cxlflash: Enable OCXL operations
7a3593e6560019ca1c3528eba1c2362cf5bddef4 scsi: cxlflash: Synchronize reset and remove ops
bcfd01d97570d8a12c6391cc0ee7f0863b81c6d4 scsi: cxlflash: Remove commmands from pending list on timeout
d54f3841703b313416c08a04848e4d97aa6a8355 scsi: cxlflash: Handle spurious interrupts

If you would rather handpick the specific commits that had deviations, please let me know and I can list them. Since 18.04 is a long term release it would help to be in sync with the upstream set of patches to avoid back porting issues in the future. Please let me know if you have questions/concerns. Thanks a LOT !

Contact Information = ***@linux.vnet.ibm.com

---uname output---
n/a

Machine Type = n/a

---Debugger---
A debugger is not configured

Stack trace output:
no

Oops output:
no

System Dump Info:
The system is not configured to capture a system dump.

*Additional Instructions for ***@linux.vnet.ibm.com:
-Attach sysctl -a output output to the bug.

** Affects: kernel-package (Ubuntu)
Importance: Undecided
Assignee: Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage)
Status: New


** Tags: architecture-ppc64le bugnameltc-167320 severity-medium targetmilestone-inin---

** Tags added: architecture-ppc64le bugnameltc-167320 severity-medium
targetmilestone-inin---

** Changed in: ubuntu
Assignee: (unassigned) => Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage)

** Package changed: ubuntu => kernel-package (Ubuntu)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kernel-package/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.com
https://lists.ubuntu.com/mailman/lis
Andrew Cloke
2018-05-02 07:40:19 UTC
Permalink
** Also affects: ubuntu-power-systems
Importance: Undecided
Status: New

** Changed in: ubuntu-power-systems
Importance: Undecided => Medium

** Changed in: ubuntu-power-systems
Assignee: (unassigned) => Canonical Kernel Team (canonical-kernel-team)

** Tags added: triage-g
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.com
https://lists.ubuntu
Frank Heimes
2018-05-02 07:45:38 UTC
Permalink
** Changed in: ubuntu-power-systems
Status: New => Triaged
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.com
https://lists.ubunt
Joseph Salisbury
2018-05-07 15:32:47 UTC
Permalink
** Package changed: kernel-package (Ubuntu) => linux (Ubuntu)

** Also affects: linux (Ubuntu Bionic)
Importance: Undecided
Status: New

** Changed in: linux (Ubuntu)
Importance: Undecided => Medium

** Changed in: linux (Ubuntu Bionic)
Importance: Undecided => Medium

** Tags added: kernel-da-key
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.co
Joseph Salisbury
2018-05-12 14:35:17 UTC
Permalink
Yes, the patches were reverted, then replaced with the ones you listed
from next/master tree. As you noticed, they did not revert cleanly, so
I had to back port and remove code that was added by newer commits.

If you could create a new patch with just the diffs that would be great!
I could revert all the cxlflash SAUCE patches and apply the ones from
next, but that would make it more difficult to get the changes into a
stable release. Changes to a stable release should be as minimal as
possible.

Just let me know if you are able to create a new patch with just the
diffs or not. If you can not, I'll build a test kernel with a revert of
all the cxlflash SAUCE patches and apply the ones from next/master.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.c
bugproxy
2018-05-11 19:40:28 UTC
Permalink
------- Comment From ***@us.ibm.com 2018-05-11 15:32 EDT-------
Can you please clarify that you have replaced the reverted patches with the patch from next/master tree ? I have provided the replacement commits for each of the revert request. Can you please confirm if this is done ?

I looked through the attachments. The reverts are not clean. It has
reverted more than it should. But I doubt if you can selectively revert
those patches because the following patches are built on top of it.

I think easiest and cleanest solution might be to revert all the
cxlflash SAUCE patches and apply the ones from next/master. Another
option is for me to create a new patch with just the differences. Please
let me know what you recommend.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.com
https://lists.ubuntu.com/mailman/l
Frank Heimes
2018-05-14 14:09:15 UTC
Permalink
** Changed in: ubuntu-power-systems
Status: Triaged => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.com
https://lis
bugproxy
2018-05-15 21:01:19 UTC
Permalink
------- Comment From ***@us.ibm.com 2018-05-15 16:57 EDT-------
I will work on the diff patch and you can apply it as additional SAUCE patch to come up to speed with the version we have in next/master and then apply the 3 new patches. I will update the BZ when the SAUCE patch with the diff is ready. Thanks !!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.co
Joseph Salisbury
2018-05-18 12:52:18 UTC
Permalink
I built a Bionic test kernel with your diff patch and the three new
patches on top.

The test kernel can be downloaded from:
http://kernel.ubuntu.com/~jsalisbury/lp1768431

Can you test this kernel and see if it resolves this bug?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.com
https://lists.ubuntu.com/
bugproxy
2018-05-17 21:10:33 UTC
Permalink
------- Comment (attachment only) From ***@us.ibm.com 2018-05-17 17:03 EDT-------


** Attachment added: "diff between v2 and v3 of CXL (cxlflash) patches"
https://bugs.launchpad.net/bugs/1768431/+attachment/5141004/+files/0001-cxlflash-OCXL-diff-between-v2-and-v3.patch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.com
https://lists.ubuntu.com/mailman/li
bugproxy
2018-05-17 21:10:32 UTC
Permalink
------- Comment From ***@us.ibm.com 2018-05-17 17:02 EDT-------
I'm attaching the diff patch that contains all the changes between the current version of SAUCE patches for latest cxlflash patches in bionic and the latest version accepted by the community. This only has the changes for the 3 differences updated earlier. After applying this diff patch, please apply the 3 additional new patches from the next/master tree. The 3 patches needed on top of this diff patch are,

a3feb6ef50def7c91244d7bd15a3625b7b49b81f scsi: cxlflash: Synchronize reset and remove ops
9a597cd4c0cebd61657f7449cb8bcb681f464500 scsi: cxlflash: Remove commmands from pending list on timeout
d2d354a606d5309fbfe81d5fca01122159e38c6e scsi: cxlflash: Handle spurious interrupts

Please let me know if you find issues applying them or if you have
questions.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1768431

Title:
Request to revert SAUCE patches in the 18.04 SRU and update with
upstream version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1768431/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-***@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu
Loading...