[Bug 1472690] [NEW] Mousepad crashes when setting tab width > 32

[Alistair Buxton]

Public bug reported:

The reproduce:

1. Open mousepad
2. Open settings
3. Go to "editor" section
4. Set tab width to 33
5. Close settings

Mousepad will now crash with an assertion error.

This is caused due to a mismatch between the gschema and the glade UI
file. The schema specifies a maximum tab width of 32 but the UI
specifies a maximum of 128. These should be brought into alignment.

http://git.xfce.org/apps/mousepad/tree/mousepad/org.xfce.mousepad.gschema.xml#n108

vs

http://git.xfce.org/apps/mousepad/tree/mousepad/mousepad-prefs-
dialog.glade#n46


In addition mousepad should probably not crash if there is a settings mismatch like this.

ProblemType: Crash
DistroRelease: Ubuntu 15.04
Package: mousepad 0.4.0-0ubuntu1
ProcVersionSignature: Ubuntu 3.19.0-22.22-generic 3.19.8-ckt1
Uname: Linux 3.19.0-22-generic i686
ApportVersion: 2.17.2-0ubuntu1.1
Architecture: i386
CurrentDesktop: XFCE
Date: Wed Jul 8 16:56:57 2015
ExecutablePath: /usr/bin/mousepad
InstallationDate: Installed on 2015-03-03 (127 days ago)
InstallationMedia: Xubuntu 15.04 "Vivid Vervet" - Alpha i386 (20150303)
ProcCmdline: mousepad
Signal: 6
SourcePackage: mousepad
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

** Affects: mousepad
Importance: Unknown
Status: Unknown

** Affects: mousepad (Ubuntu)
Importance: Undecided
Status: Confirmed


** Tags: apport-crash i386 vivid

** Information type changed from Private to Public

** Attachment removed: "CoreDump.gz"
https://bugs.launchpad.net/ubuntu/+source/mousepad/+bug/1472690/+attachment/4426459/+files/CoreDump.gz

** Tags removed: need-i386-retrace
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: mousepad (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Alistair Buxton]

** Bug watch added: Xfce Bugzilla #12055
https://bugzilla.xfce.org/show_bug.cgi?id=12055

** Also affects: mousepad via
https://bugzilla.xfce.org/show_bug.cgi?id=12055
Importance: Unknown
Status: Unknown
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Bug Watch Updater]

Launchpad has imported 1 comments from the remote bug at
https://bugzilla.xfce.org/show_bug.cgi?id=12055.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2015-07-08T16:25:36+00:00 Alistair Buxton wrote:

Created attachment 6378
Patch to fix the mismatch

Due to a mismatch between gsettings schema and UI glade.

(mousepad:27389): GLib-GIO-CRITICAL **: GObject property 'value' on a 'GtkSpinButton' object is out of schema-specified range for key 'tab-width' of 'org.xfce.mousepad.preferences.view': 33
**
GLib-GIO:ERROR:/build/buildd/glib2.0-2.40.2/./gio/gsettings.c:2389:g_settings_binding_free: assertion failed: (!binding->running)


Downstream bug https://bugs.launchpad.net/ubuntu/+source/mousepad/+bug/1472690

Patch attached.

Should mousepad really crash on errors like this? Shouldn't it be a
warning, rather than an assert/exit?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/mousepad/+bug/1472690/comments/3


** Changed in: mousepad
Status: Unknown => Confirmed

** Changed in: mousepad
Importance: Unknown => Medium
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[G-matt-8]

Thanks for reporting and fixing.

See:
http://git.xfce.org/apps/mousepad/commit/?id=15f4e5a47bd85d2cd831f65d6a66e548ad4d5708
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Bug Watch Updater]

** Changed in: mousepad
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Alberto Salvia Novella]

** Changed in: mousepad (Ubuntu)
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Jackson Doak]

debdiff adding the fix to this, as well as merging from debian,
attached.

** Patch added: "debdiff with patch"
https://bugs.launchpad.net/ubuntu/+source/mousepad/+bug/1472690/+attachment/4508736/+files/deb.diff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Sebastien Bacher]

thanks

** Changed in: mousepad (Ubuntu)
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Jackson Doak]

It appears that this is only half the fix, the .ui file needs
regenerating

** Changed in: mousepad (Ubuntu)
Status: Fix Committed => Triaged
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[SYEDFAYAZ MUJAWAR]

** Changed in: mousepad (Ubuntu)
Assignee: (unassigned) => SYEDFAYAZ MUJAWAR (syedfayaz28)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[SYEDFAYAZ MUJAWAR]

** Changed in: mousepad (Ubuntu)
Status: Triaged => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Jackson Doak]

Can you please add a reason if you're going to change this from triaged
to only confirmed?

** Changed in: mousepad (Ubuntu)
Status: Confirmed => Triaged
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions

[Launchpad Bug Tracker]

This bug was fixed in the package mousepad - 0.4.0-4ubuntu1

---------------
mousepad (0.4.0-4ubuntu1) devel; urgency=medium

* Merge from Debian unstable. Remaining changes:
- debian/control, debian/rules:
+ Switch to gtk3.
- git-width-mismatch.patch: stop a tab width related crash. LP: #1472690
* d/p/git-width-mismatch.patch:
- Update to patch the generated .h file rather than upstream glade file.

-- Unit 193 <***@ubuntu.com> Mon, 13 Jun 2016 05:45:59 +0000

** Changed in: mousepad (Ubuntu)
Status: Triaged => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1472690

Title:
Mousepad crashes when setting tab width > 32

To manage notifications about this bug go to:
https://bugs.launchpad.net/mousepad/+bug/1472690/+subscriptions